Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Helix] Don't throw on dotnet exit codes when installing aspnet app runtime #21639

Merged
merged 1 commit into from
May 11, 2020
Merged

[Helix] Don't throw on dotnet exit codes when installing aspnet app runtime #21639

merged 1 commit into from
May 11, 2020

Conversation

HaoK
Copy link
Member

@HaoK HaoK commented May 8, 2020

Operation can succeed for purposes of the tests, the tests will fail if things aren't setup properly, so we can safely ignore the errors

Related/mitigation for #20219

@HaoK
Don't throw on dotnet exit codes
485f482 
Operation can succeed for purposes of the tests, the tests will fail if things aren't setup properly, so we can safely ignore the errors
@ghost ghost added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label May 8, 2020
@HaoK HaoK changed the title Don't throw on dotnet exit codes [Helix] Don't throw on dotnet exit codes when installing aspnet app runtime May 8, 2020
@HaoK HaoK requested a review from a team May 8, 2020 21:48
@HaoK HaoK marked this pull request as ready for review May 8, 2020 23:56
@pranavkm pranavkm linked an issue May 11, 2020 that may be closed by this pull request
Exit code 139 as part of RunTests.TestRunner.InstallAspNetAppIfNeededAsync #20219
Closed
@pranavkm pranavkm mentioned this pull request May 11, 2020
Closed
@HaoK
Copy link
Member Author

HaoK commented May 11, 2020

@BrennanConroy can you review and approve?

@HaoK HaoK requested a review from BrennanConroy May 11, 2020 21:15
@HaoK HaoK merged commit 4434cf4 into master May 11, 2020
@HaoK HaoK deleted the helix/segv branch May 11, 2020 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BrennanConroy BrennanConroy BrennanConroy approved these changes

Assignees
No one assigned
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Exit code 139 as part of RunTests.TestRunner.InstallAspNetAppIfNeededAsync
2 participants
@HaoK @BrennanConroy